bpo-34443: Use __qualname__ instead of __name__ in enum exception messages.#14809
Merged
ethanfurman merged 2 commits intoJul 18, 2019
python:masterpython/cpython:masterfrom
doerwalter:enum-qualname-exceptionsdoerwalter/cpython:enum-qualname-exceptionsCopy head branch name to clipboard
Merged
bpo-34443: Use __qualname__ instead of __name__ in enum exception messages.#14809ethanfurman merged 2 commits intopython:masterpython/cpython:masterfrom doerwalter:enum-qualname-exceptionsdoerwalter/cpython:enum-qualname-exceptionsCopy head branch name to clipboard
ethanfurman merged 2 commits into
python:masterpython/cpython:masterfrom
doerwalter:enum-qualname-exceptionsdoerwalter/cpython:enum-qualname-exceptionsCopy head branch name to clipboard
Conversation
asottile
approved these changes
Jul 18, 2019
| @@ -0,0 +1,2 @@ | ||
| Exceptions from :mod:`enum` now use the `__qualname` of the enum class in |
Contributor
There was a problem hiding this comment.
Suggested change
| Exceptions from :mod:`enum` now use the `__qualname` of the enum class in | |
| Exceptions from :mod:`enum` now use the ``__qualname__`` of the enum class in |
| @@ -0,0 +1,2 @@ | ||
| Exceptions from :mod:`enum` now use the `__qualname` of the enum class in | ||
| the exception message instead of the `__name__`. |
Contributor
There was a problem hiding this comment.
Suggested change
| the exception message instead of the `__name__`. | |
| the exception message instead of the ``__name__``. |
Contributor
Author
|
OK, I've fixed the ReST markup. |
ethanfurman
approved these changes
Jul 18, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…sages. (pythonGH-14809) * Use __qualname__ instead of __name__ in enum exception messages.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…sages. (pythonGH-14809) * Use __qualname__ instead of __name__ in enum exception messages.
Contributor
|
Thanks @doerwalter for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-19166 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 25, 2020
…sages. (pythonGH-14809) * Use __qualname__ instead of __name__ in enum exception messages. (cherry picked from commit 323842c) Co-authored-by: Walter Dörwald <walter@livinglogic.de>
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…sages. (pythonGH-14809) * Use __qualname__ instead of __name__ in enum exception messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34443