[3.14] gh-143050: Correct PyLong_FromString() to use _PyLong_Negate() (GH-145901)#147331
Merged
vstinner merged 1 commit intoMar 31, 2026
python:3.14python/cpython:3.14from
miss-islington:backport-db5936c-3.14miss-islington/cpython:backport-db5936c-3.14Copy head branch name to clipboard
Merged
[3.14] gh-143050: Correct PyLong_FromString() to use _PyLong_Negate() (GH-145901)#147331vstinner merged 1 commit intopython:3.14python/cpython:3.14from miss-islington:backport-db5936c-3.14miss-islington/cpython:backport-db5936c-3.14Copy head branch name to clipboard
vstinner merged 1 commit into
python:3.14python/cpython:3.14from
miss-islington:backport-db5936c-3.14miss-islington/cpython:backport-db5936c-3.14Copy head branch name to clipboard
Conversation
…ythonGH-145901) The long_from_string_base() might return a small integer, when the _pylong.py is used to do conversion. Hence, we must be careful here to not smash it "small int" bit by using the _PyLong_FlipSign(). (cherry picked from commit db5936c) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The long_from_string_base() might return a small integer, when the
_pylong.py is used to do conversion. Hence, we must be careful here to
not smash it "small int" bit by using the _PyLong_FlipSign().
(cherry picked from commit db5936c)
Co-authored-by: Sergey B Kirpichev skirpichev@gmail.com
Co-authored-by: Victor Stinner vstinner@python.org