gh-146169: correctly handle re-entrant parsing calls in Expat handlers#146566
Open
picnixz wants to merge 7 commits into
python:mainpython/cpython:mainfrom
picnixz:fix/expat/parse-recursive-146169picnixz/cpython:fix/expat/parse-recursive-146169Copy head branch name to clipboard
Open
gh-146169: correctly handle re-entrant parsing calls in Expat handlers#146566picnixz wants to merge 7 commits intopython:mainpython/cpython:mainfrom picnixz:fix/expat/parse-recursive-146169picnixz/cpython:fix/expat/parse-recursive-146169Copy head branch name to clipboard
picnixz wants to merge 7 commits into
python:mainpython/cpython:mainfrom
picnixz:fix/expat/parse-recursive-146169picnixz/cpython:fix/expat/parse-recursive-146169Copy head branch name to clipboard
Conversation
picnixz
commented
Mar 28, 2026
Member
Author
|
@hartwork I'd like your feedback here to know whether there are other places that I need to consider. I will work on the encoding issue described in the GH issue afterwards unless they are interconnected. TiA! |
hartwork
reviewed
Mar 28, 2026
Member
Author
|
For the encoding issue, I will actually do it in a separate PR. It's not really a re-entrancy call issue, but rather an issue where you call XML_Parse() first and then you recall it later with a different string and hence have a different possible encoding. |
hartwork
reviewed
Apr 11, 2026
picnixz
commented
Apr 11, 2026
hartwork
reviewed
Apr 11, 2026
Member
Author
|
Thanks! I've left my dev session so I'll merge it tomorrow. Thanks for the review! I'll also address the encoding issue separately |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.