gh-146245: Fix ref/buffer leaks in socketmodule.c on audit hook failure#146247
Closed
kimimgo wants to merge 1 commit into
python:mainpython/cpython:mainfrom
kimimgo:fix/socket-audit-leak-146245kimimgo/cpython:fix/socket-audit-leak-146245Copy head branch name to clipboard
Closed
gh-146245: Fix ref/buffer leaks in socketmodule.c on audit hook failure#146247kimimgo wants to merge 1 commit intopython:mainpython/cpython:mainfrom kimimgo:fix/socket-audit-leak-146245kimimgo/cpython:fix/socket-audit-leak-146245Copy head branch name to clipboard
kimimgo wants to merge 1 commit into
python:mainpython/cpython:mainfrom
kimimgo:fix/socket-audit-leak-146245kimimgo/cpython:fix/socket-audit-leak-146245Copy head branch name to clipboard
Conversation
… failure Fix two leak bugs in socketmodule.c when PySys_Audit raises: 1. getaddrinfo: 'return NULL' replaced with 'goto err' to ensure idna and pstr refs are properly released via Py_XDECREF. 2. sock_sendto: Added PyBuffer_Release(&pbuf) before 'return NULL' to release the Py_buffer when audit hook raises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146245
Summary
Two leak bugs in
socketmodule.cwhenPySys_Auditraises:1.
getaddrinfo(line 6985)return NULLskipped cleanup ofidnaandpstrrefs. Changed togoto errwhich properly callsPy_XDECREFon both.2.
sock_sendto(line 4811)return NULLskippedPyBuffer_Release(&pbuf). Added the releasebefore the return, matching the pattern used in adjacent error paths.