Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-146076: Fix crash when a ZoneInfo subclass is missing a _weak_cache#146082

Merged
kumaraditya303 merged 2 commits into
python:mainpython/cpython:mainfrom
StanFromIreland:zoneinfo-weakcacgheStanFromIreland/cpython:zoneinfo-weakcacgheCopy head branch name to clipboard
Mar 18, 2026
Merged

gh-146076: Fix crash when a ZoneInfo subclass is missing a _weak_cache#146082
kumaraditya303 merged 2 commits into
python:mainpython/cpython:mainfrom
StanFromIreland:zoneinfo-weakcacgheStanFromIreland/cpython:zoneinfo-weakcacgheCopy head branch name to clipboard

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Mar 17, 2026

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@kumaraditya303 kumaraditya303 merged commit 3b06d68 into python:main Mar 18, 2026
56 checks passed
@StanFromIreland StanFromIreland deleted the zoneinfo-weakcacghe branch March 18, 2026 13:46
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 18, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2026
…weak_cache` (pythonGH-146082)

(cherry picked from commit 3b06d68)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2026
…weak_cache` (pythonGH-146082)

(cherry picked from commit 3b06d68)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Mar 18, 2026

Copy link
Copy Markdown

GH-146115 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 18, 2026
@bedevere-app

bedevere-app Bot commented Mar 18, 2026

Copy link
Copy Markdown

GH-146116 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 18, 2026
serhiy-storchaka pushed a commit that referenced this pull request Mar 18, 2026
…_weak_cache` (GH-146082) (GH-146115)

(cherry picked from commit 3b06d68)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Mar 18, 2026
…_weak_cache` (GH-146082) (GH-146116)

(cherry picked from commit 3b06d68)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland

Copy link
Copy Markdown
Member Author

Thanks for the reviews and backports!

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.