gh-146075: Prevent crash in functools.partial() from malformed str subclass#146078
Merged
Merged
gh-146075: Prevent crash in functools.partial() from malformed str subclass#146078
functools.partial() from malformed str subclass#146078Conversation
In `partial_vectorcall`, an error returned by `PyDict_Contains` was considered to be a truthy value. Now, the error is handled appropriately.
str subclassfunctools.partial() from malformed str subclass
skirpichev
approved these changes
Mar 17, 2026
skirpichev
left a comment
Member
There was a problem hiding this comment.
LGTM
Test failures look unrelated.
kumaraditya303
approved these changes
Mar 18, 2026
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…d `str` subclass (pythonGH-146078) In `partial_vectorcall`, an error returned by `PyDict_Contains` was considered to be a truthy value. Now, the error is handled appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
partial_vectorcall, an error returned byPyDict_Containswas considered to be a truthy value. Now, the error is handled appropriately.functools.partialusing astrsubclass that raises on__eq__#146075