Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-37483: fix refleak#14599

Closed
methane wants to merge 2 commits into
python:masterpython/cpython:masterfrom
methane:fix-refleakmethane/cpython:fix-refleakCopy head branch name to clipboard
Closed

bpo-37483: fix refleak#14599
methane wants to merge 2 commits into
python:masterpython/cpython:masterfrom
methane:fix-refleakmethane/cpython:fix-refleakCopy head branch name to clipboard

Conversation

@methane

@methane methane commented Jul 5, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@methane methane added skip news type-bug An unexpected behavior, bug, or error labels Jul 5, 2019
jdemeyer
jdemeyer requested changes Jul 5, 2019
View reviewed changes

@jdemeyer jdemeyer left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to initialize v = NULL and you need to handle the case v == NULL in onError. See #14600

@methane methane closed this Jul 5, 2019
@methane methane deleted the fix-refleak branch July 5, 2019 10:23
@methane methane restored the fix-refleak branch July 5, 2019 10:24
@methane methane reopened this Jul 5, 2019
@methane

methane commented Jul 5, 2019

Copy link
Copy Markdown
Member Author

You need to initialize v = NULL and you need to handle the case v == NULL in onError. See #14600

Why?

    v = normalizestring(encoding);
    if (v == NULL)
        goto onError;
    PyUnicode_InternInPlace(&v);

@methane methane closed this Jul 5, 2019
@methane

methane commented Jul 5, 2019

Copy link
Copy Markdown
Member Author

I'm sorry, I found it myself.

@methane methane deleted the fix-refleak branch July 5, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdemeyer jdemeyer jdemeyer requested changes

Assignees

No one assigned

Labels

awaiting core review skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane @jdemeyer @the-knights-who-say-ni @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.