Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-145056: Accept frozendict in xml.etree#145508

Merged
vstinner merged 2 commits into
python:mainpython/cpython:mainfrom
vstinner:frozendict_etreevstinner/cpython:frozendict_etreeCopy head branch name to clipboard
Mar 5, 2026
Merged

gh-145056: Accept frozendict in xml.etree#145508
vstinner merged 2 commits into
python:mainpython/cpython:mainfrom
vstinner:frozendict_etreevstinner/cpython:frozendict_etreeCopy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Mar 4, 2026

Copy link
Copy Markdown
Member

Element and SubElement of xml.etree.ElementTree now also accept frozendict as attrib.


📚 Documentation preview 📚: https://cpython-previews--145508.org.readthedocs.build/

Element and SubElement of xml.etree.ElementTree now also accept
frozendict as attrib.
@vstinner

vstinner commented Mar 4, 2026

Copy link
Copy Markdown
Member Author

I prefer to wait until #145517 is merged before merging this PR, so I mark this PR as a draft for now.

@vstinner vstinner marked this pull request as ready for review March 5, 2026 11:53
@vstinner vstinner merged commit 7bdfce0 into python:main Mar 5, 2026
53 of 54 checks passed
@vstinner vstinner deleted the frozendict_etree branch March 5, 2026 11:55
@vstinner

vstinner commented Mar 5, 2026

Copy link
Copy Markdown
Member Author

I prefer to wait until #145517 is merged before merging this PR, so I mark this PR as a draft for now.

The situation looks more complicated than what I expected. So I merged this change with the temporary solution: _PyDict_CopyAsDict() function.

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
Element and SubElement of xml.etree.ElementTree now also accept
frozendict for attrib.

Export _PyDict_CopyAsDict() function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.