gh-142927: Tachyon: Fix singular and plurals#145329
Merged
Merged
gh-142927: Tachyon: Fix singular and plurals#145329
Conversation
hugovk
commented
Feb 27, 2026
Comment on lines
+151
to
+153
| f"Flamegraph data: {num_functions} root function{s1}, " | ||
| f"{total_time} total sample{s2}, " | ||
| f"{string_count} unique string{s3}" |
Member
Author
There was a problem hiding this comment.
This was:
Flamegraph data: X root functions, total samples: Y, Z unique strings
I also changed the order of the middle one for consistency:
Flamegraph data: X root functions, Y total samples, Z unique strings
pablogsal
approved these changes
Feb 27, 2026
Member
|
Thanks @hugovk |
brijkapadia
pushed a commit
to brijkapadia/cpython
that referenced
this pull request
Feb 28, 2026
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some more like #142934, spotted some of these can be 1 in #145306 (comment).