Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions 5 Lib/test/test_sqlite3/test_dbapi.py
Original file line number Diff line number Diff line change
Expand Up @@ -1387,6 +1387,11 @@ def test_blob_get_slice(self):
def test_blob_get_empty_slice(self):
self.assertEqual(self.blob[5:5], b"")

def test_blob_get_empty_slice_oob_indices(self):
self.cx.execute("insert into test(b) values (?)", (b"abc",))
with self.cx.blobopen("test", "b", 2) as blob:
self.assertEqual(blob[5:-5], b"")

def test_blob_get_slice_negative_index(self):
self.assertEqual(self.blob[5:-5], self.data[5:-5])

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix assertion failure in :mod:`sqlite3` blob subscript when slicing with
indices that result in an empty slice.
4 changes: 4 additions & 0 deletions 4 Modules/_sqlite/blob.c
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,10 @@ subscript_slice(pysqlite_Blob *self, PyObject *item)
return NULL;
}

if (len == 0) {
return PyBytes_FromStringAndSize(NULL, 0);
}

if (step == 1) {
return read_multiple(self, len, start);
}
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.