Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix unlikely potential reference leak in _locale._getdefaultlocale#145250

Merged
serhiy-storchaka merged 2 commits into
python:mainpython/cpython:mainfrom
serhiy-storchaka:_locale-_getdefaultlocale-leakserhiy-storchaka/cpython:_locale-_getdefaultlocale-leakCopy head branch name to clipboard
Feb 27, 2026
Merged

Fix unlikely potential reference leak in _locale._getdefaultlocale#145250
serhiy-storchaka merged 2 commits into
python:mainpython/cpython:mainfrom
serhiy-storchaka:_locale-_getdefaultlocale-leakserhiy-storchaka/cpython:_locale-_getdefaultlocale-leakCopy head branch name to clipboard

Conversation

@serhiy-storchaka

Copy link
Copy Markdown
Member

It occurs in a code which perhaps never executed.

The bug was here from the beginning, from 8f017a0.

It occurs in a code which perhaps never executed.
@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 26, 2026
@serhiy-storchaka serhiy-storchaka changed the title Fix unlikely ptential reference leak in _locale._getdefaultlocale Fix unlikely potential reference leak in _locale._getdefaultlocale Feb 26, 2026

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) February 27, 2026 07:36
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) February 27, 2026 07:36
@serhiy-storchaka serhiy-storchaka merged commit 6ea84b2 into python:main Feb 27, 2026
45 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2026
…ythonGH-145250)

It occurs in a code which perhaps never executed.
(cherry picked from commit 6ea84b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2026
…ythonGH-145250)

It occurs in a code which perhaps never executed.
(cherry picked from commit 6ea84b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented Feb 27, 2026

Copy link
Copy Markdown

GH-145302 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Feb 27, 2026
@bedevere-app

bedevere-app Bot commented Feb 27, 2026

Copy link
Copy Markdown

GH-145303 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Feb 27, 2026
@serhiy-storchaka serhiy-storchaka deleted the _locale-_getdefaultlocale-leak branch February 27, 2026 08:17
serhiy-storchaka added a commit that referenced this pull request Feb 27, 2026
…cale (GH-145250) (GH-145302)

It occurs in a code which perhaps never executed.
(cherry picked from commit 6ea84b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
serhiy-storchaka added a commit that referenced this pull request Mar 24, 2026
…cale (GH-145250) (GH-145303)

It occurs in a code which perhaps never executed.
(cherry picked from commit 6ea84b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.