gh-142927: Detect system theme in flame graph like in heatmap#144885
Merged
hugovk merged 2 commits intoMar 10, 2026
python:mainpython/cpython:mainfrom
hugovk:3.15-tachyon-heatmap-detect-themehugovk/cpython:3.15-tachyon-heatmap-detect-themeCopy head branch name to clipboard
Merged
gh-142927: Detect system theme in flame graph like in heatmap#144885hugovk merged 2 commits intopython:mainpython/cpython:mainfrom hugovk:3.15-tachyon-heatmap-detect-themehugovk/cpython:3.15-tachyon-heatmap-detect-themeCopy head branch name to clipboard
hugovk merged 2 commits into
python:mainpython/cpython:mainfrom
hugovk:3.15-tachyon-heatmap-detect-themehugovk/cpython:3.15-tachyon-heatmap-detect-themeCopy head branch name to clipboard
Conversation
pablogsal
approved these changes
Feb 16, 2026
Member
|
Thanks @hugovk ❤️ |
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The heatmap initially detects the user's preferred theme (via
prefers-color-scheme) but the flame graph does not.This PR allows the flame graph to do the same, and refactors some shared JavaScript code into a new
base.jsfile to avoid duplication.