Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions 16 Lib/test/test_descr.py
Original file line number Diff line number Diff line change
Expand Up @@ -5361,6 +5361,22 @@ def foo(self):
with self.assertRaisesRegex(NotImplementedError, "BAR"):
B().foo

def test_reentrant_hash_during_setattr_delattr(self):
class Evil(str):
def __hash__(self):
old_dict = target.__dict__
target.__dict__ = {}
del old_dict
return super().__hash__()
class Target:
pass
target = Target()
setattr(target, Evil("marker"), 123)
try:
delattr(target, Evil("marker"))
except AttributeError:
pass


class DictProxyTests(unittest.TestCase):
def setUp(self):
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix a potential use-after-free crash when setting or deleting instance
attributes if a re-entrant ``__hash__`` implementation mutates the instance
``__dict__`` during attribute handling.
10 changes: 8 additions & 2 deletions 10 Objects/dictobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -6983,7 +6983,10 @@ _PyObject_StoreInstanceAttribute(PyObject *obj, PyObject *name, PyObject *value)
Py_DECREF(dict);
return res;
}
return store_instance_attr_dict(obj, dict, name, value);
Py_INCREF(dict);
int res = store_instance_attr_dict(obj, dict, name, value);
Py_DECREF(dict);
return res;
}

#ifdef Py_GIL_DISABLED
Expand Down Expand Up @@ -7012,7 +7015,10 @@ _PyObject_StoreInstanceAttribute(PyObject *obj, PyObject *name, PyObject *value)
return res;
}
}
return store_instance_attr_dict(obj, dict, name, value);
Py_INCREF((PyObject *)dict);
int res = store_instance_attr_dict(obj, dict, name, value);
Py_DECREF((PyObject *)dict);
return res;
#else
return store_instance_attr_lock_held(obj, values, name, value);
#endif
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.