gh-142913: fix _testinternalcapi build failure due to undefined JIT symbols#143949
Closed
cocolato wants to merge 1 commit into
Closed
gh-142913: fix _testinternalcapi build failure due to undefined JIT symbols#143949cocolato wants to merge 1 commit into
_testinternalcapi build failure due to undefined JIT symbols#143949cocolato wants to merge 1 commit into
Conversation
_testinternalcapi build failure due to undefined JIT symbols_testinternalcapi build failure due to undefined JIT symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause:
The fix in 949b5ec removed the Tier 2 interpreter loop from
Modules/_testinternalcapi/interpreter.c, buttest_cases.c.his generated fromPython/bytecodes.cand still contains theTRACE_RECORDandTRACE_ENDinstructions which call:_PyJit_translate_single_bytecode_to_trace()_PyJit_TryInitializeTracing()_PyJit_FinalizeTracing()These functions are defined in
Python/optimizer.cbut are not exported (missingPyAPI_FUNC), causing link failures when building the shared library.