Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-138122: Remove default duration for statistical profiling#143174

Merged
pablogsal merged 5 commits into
python:mainpython/cpython:mainfrom
lkollar:profiling/no-default-durationlkollar/cpython:profiling/no-default-durationCopy head branch name to clipboard
Dec 25, 2025
Merged

gh-138122: Remove default duration for statistical profiling#143174
pablogsal merged 5 commits into
python:mainpython/cpython:mainfrom
lkollar:profiling/no-default-durationlkollar/cpython:profiling/no-default-durationCopy head branch name to clipboard

Conversation

@lkollar

@lkollar lkollar commented Dec 25, 2025

Copy link
Copy Markdown
Contributor

Instead of limiting profiling to 10s, let the process finish by default.

Towards #142927

Instead of limiting profiling to 10s, let the process finish by default.
@pablogsal

Copy link
Copy Markdown
Member

I think we still need to update the docs

@pablogsal

Copy link
Copy Markdown
Member

I think sample.py still has references to duration_sec=10

@pablogsal

Copy link
Copy Markdown
Member

Pushed a small fix with the items left and a (somehow related) bug I found while testing

@pablogsal pablogsal enabled auto-merge (squash) December 25, 2025 18:24
@pablogsal pablogsal disabled auto-merge December 25, 2025 18:24
@pablogsal pablogsal enabled auto-merge (squash) December 25, 2025 18:24
@picnixz picnixz changed the title gh-138122: Remove default duration gh-138122: Remove default duration for statistical profiling Dec 25, 2025
@pablogsal pablogsal disabled auto-merge December 25, 2025 18:43
@pablogsal pablogsal enabled auto-merge (squash) December 25, 2025 18:46
@pablogsal pablogsal disabled auto-merge December 25, 2025 19:12
@pablogsal pablogsal enabled auto-merge (squash) December 25, 2025 19:12
@pablogsal pablogsal merged commit 888d101 into python:main Dec 25, 2025
46 checks passed
@lkollar lkollar deleted the profiling/no-default-duration branch December 25, 2025 20:06
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
…ython#143174)

Co-authored-by: Pablo Galindo Salgado <pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.