gh-134584: Revert partially #135860#142620
Merged
Fidget-Spinner merged 2 commits intoDec 12, 2025
python:mainpython/cpython:mainfrom
Fidget-Spinner:partial_revert_135860Fidget-Spinner/cpython:partial_revert_135860Copy head branch name to clipboard
Merged
gh-134584: Revert partially #135860#142620Fidget-Spinner merged 2 commits intopython:mainpython/cpython:mainfrom Fidget-Spinner:partial_revert_135860Fidget-Spinner/cpython:partial_revert_135860Copy head branch name to clipboard
Fidget-Spinner merged 2 commits into
python:mainpython/cpython:mainfrom
Fidget-Spinner:partial_revert_135860Fidget-Spinner/cpython:partial_revert_135860Copy head branch name to clipboard
Conversation
35 tasks
Contributor
|
Should I change #136070 to avoid the refleak? |
vstinner
approved these changes
Dec 12, 2025
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM: I confirm that this change fix the refleak. I didn't review the change itself, it just looks good to me :-)
$ ./python -m test test.test_multiprocessing_fork.test_threads -R 3:3
(...)
Result: SUCCESS
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a refleak.