Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-138122: Add docs button to Tachyon heatmap and flamegraph#142614

Merged
pablogsal merged 1 commit into
python:mainpython/cpython:mainfrom
StanFromIreland:tachyon-docs-linkStanFromIreland/cpython:tachyon-docs-linkCopy head branch name to clipboard
Dec 12, 2025
Merged

gh-138122: Add docs button to Tachyon heatmap and flamegraph#142614
pablogsal merged 1 commit into
python:mainpython/cpython:mainfrom
StanFromIreland:tachyon-docs-linkStanFromIreland/cpython:tachyon-docs-linkCopy head branch name to clipboard

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Dec 12, 2025

Copy link
Copy Markdown
Member

I have also converted it to use SVG's from bootstrap icons, I can revert back to characters if you prefer. This is because I had difficulties with the characters, it was difficult to align them, e.g. it ended up looking like this:

Screenshot From 2025-12-11 21-56-24

With SVG's, we have more control over how it renders, with this PR:

heatmap icons flamegraph icons

And, this PR also introduces a new docs (book) button that links to:

https://docs.python.org/PYTHON_VERSION_USED/library/profiling.sampling.html

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work sir!

@pablogsal pablogsal merged commit 340a684 into python:main Dec 12, 2025
87 of 89 checks passed
@StanFromIreland StanFromIreland deleted the tachyon-docs-link branch December 12, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.