Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.14] gh-141732: Fix ExceptionGroup repr changing when original exception sequence is mutated (GH-141736)#142388

Closed
miss-islington wants to merge 3 commits into
python:3.14python/cpython:3.14from
miss-islington:backport-ff2577f-3.14miss-islington/cpython:backport-ff2577f-3.14Copy head branch name to clipboard
Closed

[3.14] gh-141732: Fix ExceptionGroup repr changing when original exception sequence is mutated (GH-141736)#142388
miss-islington wants to merge 3 commits into
python:3.14python/cpython:3.14from
miss-islington:backport-ff2577f-3.14miss-islington/cpython:backport-ff2577f-3.14Copy head branch name to clipboard

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 7, 2025

Copy link
Copy Markdown
Contributor

…eption sequence is mutated (pythonGH-141736)

(cherry picked from commit ff2577f)

Co-authored-by: dr-carlos <77367421+dr-carlos@users.noreply.github.com>
@picnixz picnixz dismissed a stale review December 7, 2025 23:11

spam review

pablogsal

This comment was marked as outdated.

@hugovk

hugovk commented Feb 3, 2026

Copy link
Copy Markdown
Member

CI is failing:

Objects/exceptions.c:1954:34: error: too few arguments provided to function-like macro invocation
                        "module.");
                                 ^
Objects/exceptions.c:696:9: note: macro 'ComplexExtendsException' defined here
#define ComplexExtendsException(EXCBASE, EXCNAME, EXCSTORE, EXCNEW, \
        ^
Objects/exceptions.c:1949:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
ComplexExtendsException(PyExc_Exception, ImportError,
^
int
Objects/exceptions.c:1960:1: error: use of undeclared identifier '_PyExc_ImportError'; did you mean 'PyExc_ImportError'?
MiddlingExtendsException(PyExc_ImportError, ModuleNotFoundError, ImportError,
^
Objects/exceptions.c:692:12: note: expanded from macro 'MiddlingExtendsException'
    static MiddlingExtendsExceptionEx( \
           ^
Objects/exceptions.c:686:47: note: expanded from macro 'MiddlingExtendsExceptionEx'
    EXCSTORE ## _clear, 0, 0, 0, 0, 0, 0, 0, &_ ## EXCBASE, \
                                              ^
<scratch space>:21:1: note: expanded from here
_PyExc_ImportError
^
./Include/pyerrors.h:93:24: note: 'PyExc_ImportError' declared here
PyAPI_DATA(PyObject *) PyExc_ImportError;
                       ^
Objects/exceptions.c:1960:1: warning: incompatible pointer types initializing 'PyTypeObject *' (aka 'struct _typeobject *') with an expression of type 'PyObject **' (aka 'struct _object **') [-Wincompatible-pointer-types]
MiddlingExtendsException(PyExc_ImportError, ModuleNotFoundError, ImportError,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Objects/exceptions.c:692:12: note: expanded from macro 'MiddlingExtendsException'
    static MiddlingExtendsExceptionEx( \
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Objects/exceptions.c:686:46: note: expanded from macro 'MiddlingExtendsExceptionEx'
    EXCSTORE ## _clear, 0, 0, 0, 0, 0, 0, 0, &_ ## EXCBASE, \
                                             ^~~~~~~~~~~~~
Objects/exceptions.c:4338:5: error: use of undeclared identifier '_PyExc_ImportError'; did you mean 'PyExc_ImportError'?
    ITEM(ImportError),
    ^
Objects/exceptions.c:4320:22: note: expanded from macro 'ITEM'
#define ITEM(NAME) {&_PyExc_##NAME, #NAME}
                     ^
<scratch space>:62:1: note: expanded from here
_PyExc_ImportError
^
./Include/pyerrors.h:93:24: note: 'PyExc_ImportError' declared here
PyAPI_DATA(PyObject *) PyExc_ImportError;
                       ^
Objects/exceptions.c:4338:5: warning: incompatible pointer types initializing 'PyTypeObject *' (aka 'struct _typeobject *') with an expression of type 'PyObject **' (aka 'struct _object **') [-Wincompatible-pointer-types]
    ITEM(ImportError),
    ^~~~~~~~~~~~~~~~~
Objects/exceptions.c:4320:21: note: expanded from macro 'ITEM'
#define ITEM(NAME) {&_PyExc_##NAME, #NAME}
                    ^~~~~~~~~~~~~~
2 warnings and 4 errors generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.