Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-141658: JIT: lazy executor flush while the world is stopped #142329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maurycy wants to merge 2 commits into from
Closed

gh-141658: JIT: lazy executor flush while the world is stopped #142329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
242ddf4
jit: lazy executor flush while the world stopped
maurycy Dec 6, 2025
48f6b6b
blurb
maurycy Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions 2 Misc/NEWS.d/next/Core_and_Builtins/2025-12-06-01-25-04.gh-issue-141658.g039M-.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix a deadlock where JIT executor drain could run under the rutime lock when
invalidations overflow the pending list.
13 changes: 12 additions & 1 deletion 13 Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,17 @@ _Py_ClearExecutorDeletionList(PyInterpreterState *interp)
interp->executor_deletion_list_remaining_capacity = EXECUTOR_DELETE_LIST_MAX;
}

static inline int
can_clear_executor_deletion_list(PyInterpreterState *interp)
{
#ifdef Py_GIL_DISABLED
if (_PyRuntime.stoptheworld.world_stopped || interp->stoptheworld.world_stopped) {

@Fidget-Spinner Fidget-Spinner Dec 6, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need FT atomic reads here?

return 0;
}
#endif
return 1;

@Fidget-Spinner Fidget-Spinner Dec 6, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? It's still not safe even with the GIL.

}

static void
add_to_pending_deletion_list(_PyExecutorObject *self)
{
Expand All @@ -302,7 +313,7 @@ add_to_pending_deletion_list(_PyExecutorObject *self)
if (interp->executor_deletion_list_remaining_capacity > 0) {
interp->executor_deletion_list_remaining_capacity--;
}
else {
else if (can_clear_executor_deletion_list(interp)) {
_Py_ClearExecutorDeletionList(interp);
}
}
Expand Down
12 changes: 12 additions & 0 deletions 12 Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2358,6 +2358,18 @@ start_the_world(struct _stoptheworld_state *stw)
_PyRuntimeState *runtime = &_PyRuntime;
assert(PyMutex_IsLocked(&stw->mutex));

#ifdef _Py_TIER2
if (stw->is_global) {
_Py_FOR_EACH_STW_INTERP(stw, interp) {
_Py_ClearExecutorDeletionList(interp);
}
}
else {
PyInterpreterState *interp = _Py_CONTAINER_OF(stw, PyInterpreterState, stoptheworld);
_Py_ClearExecutorDeletionList(interp);
}
#endif

HEAD_LOCK(runtime);
stw->requested = 0;
stw->world_stopped = 0;
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.