Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-141786: Fix missing parent executor during JIT of trace#142286

Closed
caje731 wants to merge 1 commit into
python:mainpython/cpython:mainfrom
caje731:gh-141786caje731/cpython:gh-141786Copy head branch name to clipboard
Closed

gh-141786: Fix missing parent executor during JIT of trace#142286
caje731 wants to merge 1 commit into
python:mainpython/cpython:mainfrom
caje731:gh-141786caje731/cpython:gh-141786Copy head branch name to clipboard

Conversation

@caje731

@caje731 caje731 commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

@python-cla-bot

python-cla-bot Bot commented Dec 5, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@picnixz

picnixz commented Dec 5, 2025

Copy link
Copy Markdown
Member

It is customary to ask on the issue if one can create a PR for the patch before doing it, especially if someone is already assigned to the issue. If the assignee has already started working on it, it should be done so to avoid synchronization issues. Sorry, but I will close the PR for now (in addition, tests seem to be broken by this change) (you can still work on it on your fork but we try to avoid open PRs sitting there).

If the assignee wants to delegate the work, I'll re-open the PR (but the tests need to pass, and regression tests must be added as well)

@picnixz picnixz closed this Dec 5, 2025
@Fidget-Spinner

Copy link
Copy Markdown
Member

The check in crval.c is wrong.

You need to move the following checks into this line. So it should be a nested if.

@Fidget-Spinner

Copy link
Copy Markdown
Member

@picnixz I'm helping the OP with creating a PR for this. So I let them take the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.