Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-37325: Fix focus traversal for 2 IDLE dialogs#14209

Merged
terryjreedy merged 5 commits into
python:masterpython/cpython:masterfrom
terryjreedy:traverseterryjreedy/cpython:traverseCopy head branch name to clipboard
Jun 18, 2019
Merged

bpo-37325: Fix focus traversal for 2 IDLE dialogs#14209
terryjreedy merged 5 commits into
python:masterpython/cpython:masterfrom
terryjreedy:traverseterryjreedy/cpython:traverseCopy head branch name to clipboard

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Jun 18, 2019

Copy link
Copy Markdown
Member

Tab now moves focus across and down for Help Source and Custom Run.

https://bugs.python.org/issue37325

@terryjreedy

terryjreedy commented Jun 18, 2019

Copy link
Copy Markdown
Member Author

A simple change works for me and this should not depend on OS, so I will merge when CI passes. Cheryl, thanks for the great start on the dialog.

@terryjreedy terryjreedy merged commit 54cf2e0 into python:master Jun 18, 2019
@bedevere-bot

Copy link
Copy Markdown

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@bedevere-bot

Copy link
Copy Markdown

GH-14210 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2019
Tab now moves focus across and down for Help Source and Custom Run.
(cherry picked from commit 54cf2e0)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy terryjreedy deleted the traverse branch June 18, 2019 21:09
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-14211 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 18, 2019
Tab now moves focus across and down for Help Source and Custom Run.
(cherry picked from commit 54cf2e0)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Jun 18, 2019
Tab now moves focus across and down for Help Source and Custom Run.
(cherry picked from commit 54cf2e0)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
Tab now moves focus across and down for Help Source and Custom Run.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Tab now moves focus across and down for Help Source and Custom Run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.