gh-141732: Fix `ExceptionGroup` repr changing when original exception sequence is mutated#141736

Merged

iritkatriel merged 45 commits into

python:mainfrom

dr-carlos:exception-group-repr

Dec 7, 2025

Commits on Nov 19, 2025

Use `self.exceptions` in `BaseExceptionGroup` repr by supporting custom reprs in `ComplexExtendsException`
dr-carlos
committed
b1afcb8
Copy full SHA for b1afcb8
Update `ExceptionGroup` tests for new repr and add mutation test
dr-carlos
committed
59bc3c7
Copy full SHA for 59bc3c7
Fix typo in test comment
dr-carlos
committed
ca2d21d
Copy full SHA for ca2d21d
Update docs for `BaseExceptionGroup` repr change
dr-carlos
committed
493ab01
Copy full SHA for 493ab01
Add NEWS entry
dr-carlos
committed
cd90d51
Copy full SHA for cd90d51
Update `ExceptionGroup` repr in `test_traceback`
dr-carlos
committed
177b535
Copy full SHA for 177b535

Commits on Nov 21, 2025

Revert "Update `ExceptionGroup` repr in `test_traceback`"
Show description for af4f086
dr-carlos
committed
af4f086
Copy full SHA for af4f086
Update `ExceptionGroup` tests to no longer change the repr
dr-carlos
committed
72918ea
Copy full SHA for 72918ea
Store exceptions copy in `BaseExceptionGroup->excs_orig` and use in `repr`
dr-carlos
committed
b45402a
Copy full SHA for b45402a
Revert "Update docs for `BaseExceptionGroup` repr change"
Show description for 62d72a4
dr-carlos
committed
62d72a4
Copy full SHA for 62d72a4
Remove `BaseExceptionGroup->excs_orig` and reconstruct in `repr` instead
dr-carlos
committed
f93ae8f
Copy full SHA for f93ae8f
Ensure that the exceptions copy in `BaseExceptionGroup` repr is freed
dr-carlos
committed
56eefee
Copy full SHA for 56eefee

Commits on Nov 22, 2025

Move `ExceptionGroup` repr tests into new function
dr-carlos
committed
79dd615
Copy full SHA for 79dd615
Use the exceptions tuple for all non-lists in `ExceptionGroup` repr
dr-carlos
committed
e9fec3d
Copy full SHA for e9fec3d
Test custom sequence's `ExceptionGroup` repr
dr-carlos
committed
f5acfef
Copy full SHA for f5acfef
Update code style in `exceptions.c`
Show description for 2fca592

dr-carlos
and
picnixz
authored
2fca592
Copy full SHA for 2fca592
Update code style in `exceptions.c`
Show description for 4885a6b

dr-carlos
and
picnixz
authored
4885a6b
Copy full SHA for 4885a6b

Commits on Nov 23, 2025

Remove unused `name` variable with new `%Y` format
dr-carlos
committed
4801399
Copy full SHA for 4801399
Revert "Remove unused `name` variable with new `%Y` format"
Show description for 1bcddeb
dr-carlos
committed
1bcddeb
Copy full SHA for 1bcddeb
Revert "Update code style in `exceptions.c`"
Show description for ccef7c5
dr-carlos
committed
ccef7c5
Copy full SHA for ccef7c5

Commits on Nov 25, 2025

Save repr of non-standard sequences in `BaseExceptionGroup` constructor
dr-carlos
committed
9ca573e
Copy full SHA for 9ca573e
Update tests for non-standard exceptions sequence in `ExceptionGroup`
dr-carlos
committed
9531fe9
Copy full SHA for 9531fe9
Document implementation details for `ExceptionGroup` exception sequence
dr-carlos
committed
1da9238
Copy full SHA for 1da9238

Commits on Nov 26, 2025

Update Misc/NEWS.d/next/Core_and_Builtins/2025-11-19-16-40-24.gh-issue-141732.PTetqp.rst
iritkatriel
authored
fcaf314
Copy full SHA for fcaf314
Merge branch 'main' into exception-group-repr
iritkatriel
authored
2c67e71
Copy full SHA for 2c67e71
Reword 'optimum' to 'optimal' in `exceptions.rst`
dr-carlos
committed
d962581
Copy full SHA for d962581
Update NEWS Entry
Show description for ce39eec

dr-carlos
and
picnixz
authored
ce39eec
Copy full SHA for ce39eec
Handle error on `__repr__` for exceptions sequence passed to `ExceptionGroup()`
dr-carlos
committed
9211d01
Copy full SHA for 9211d01
Change grammar in `exceptions.c`
Show description for 737206a

dr-carlos
and
picnixz
authored
737206a
Copy full SHA for 737206a
Update comment relating to `Py_XNewRef` in `BaseExceptionGroup_repr()`
dr-carlos
committed
8d17ef3
Copy full SHA for 8d17ef3
Handle `PySequence_List()` and `PyObject_Repr()` errors in `BaseException_repr()`
dr-carlos
committed
383af2f
Copy full SHA for 383af2f
Conditionally use `Py_NewRef` in `BaseExceptionGroup_repr()`
dr-carlos
committed
5353340
Copy full SHA for 5353340
Refactor `goto error` into `return NULL` within `BaseExceptionGroup_repr()`
dr-carlos
committed
9997c01
Copy full SHA for 9997c01
Test custom sequences which raise errors in the `ExceptionGroup()` constructor
dr-carlos
committed
3cd38db
Copy full SHA for 3cd38db
Fix formatting of if-else in `exceptions.c`
dr-carlos
committed
5feb970
Copy full SHA for 5feb970
Simplify f-string to normal str in `test_exceptions_mutation()`
dr-carlos
committed
d7aec51
Copy full SHA for d7aec51
Remove unnecessary `_exceptions_str` member of `ExceptionGroup`
dr-carlos
committed
e21fad0
Copy full SHA for e21fad0
Fix if-else formatting in `exceptions.c`
dr-carlos
committed
79094f6
Copy full SHA for 79094f6
Keep lines less than 80 chars
dr-carlos
committed
b5fcfa7
Copy full SHA for b5fcfa7

Commits on Nov 27, 2025

Revert "Fix formatting of if-else in `exceptions.c`"
Show description for 57f8bf6
dr-carlos
committed
57f8bf6
Copy full SHA for 57f8bf6
Construct custom sequence outside of `assertRaises` context manager in `test_repr_raises()`
dr-carlos
committed
9cba6b6
Copy full SHA for 9cba6b6
Swap order of if-else branches and clarify comment in `BaseExceptionGroup_repr()`
dr-carlos
committed
d61e6b9
Copy full SHA for d61e6b9

Commits on Dec 5, 2025

Merge branch 'main' into exception-group-repr
iritkatriel
authored
8e455fd
Copy full SHA for 8e455fd

Commits on Dec 7, 2025

Merge branch 'main' into exception-group-repr
iritkatriel
authored
b75a12e
Copy full SHA for b75a12e
Merge branch 'main' into exception-group-repr
iritkatriel
authored
85cc2aa
Copy full SHA for 85cc2aa