Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.14] gh-139707: Add docs for optional modules (GH-140171)#141204

Merged
encukou merged 1 commit into
python:3.14python/cpython:3.14from
StanFromIreland:backport-d2ce6d7-3.14StanFromIreland/cpython:backport-d2ce6d7-3.14Copy head branch name to clipboard
Nov 10, 2025
Merged

[3.14] gh-139707: Add docs for optional modules (GH-140171)#141204
encukou merged 1 commit into
python:3.14python/cpython:3.14from
StanFromIreland:backport-d2ce6d7-3.14StanFromIreland/cpython:backport-d2ce6d7-3.14Copy head branch name to clipboard

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Nov 7, 2025

Copy link
Copy Markdown
Member

(cherry picked from commit d2ce6d7)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Emma Smith <emma@emmatyping.dev>
Co-authored-by: Author: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Victor Stinner <vstinner@python.org>
Comment thread Doc/library/zlib.rst
has its own home page at https://www.zlib.net. There are known
incompatibilities between the Python module and versions of the zlib library
earlier than 1.1.3; 1.1.3 has a `security vulnerability <https://zlib.net/zlib_faq.html#faq33>`_, so we recommend using
1.1.4 or later.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the conflict, I recently bumped this to the actual minimum (we error during building otherwise), it wasn't backported but there is no difference on 3.14, I can change it if we prefer to keep it at (the technically impossible) 1.1.4.

#if defined(ZLIB_VERNUM) && ZLIB_VERNUM < 0x1221
#error "At least zlib version 1.2.2.1 is required"
#endif

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

You're effectively backporting the other docs fix. I mentioned this PR on your earlier one.

@encukou encukou merged commit c12a0be into python:3.14 Nov 10, 2025
36 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 10, 2025
@StanFromIreland StanFromIreland deleted the backport-d2ce6d7-3.14 branch November 10, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.