[3.8] bpo-36402: Fix threading._shutdown() race condition (GH-13948)#14033
[3.8] bpo-36402: Fix threading._shutdown() race condition (GH-13948)#14033miss-islington wants to merge 1 commit intopython:3.8python/cpython:3.8from miss-islington:backport-468e5fe-3.8miss-islington/cpython:backport-468e5fe-3.8Copy head branch name to clipboard
Conversation
Fix a race condition at Python shutdown when waiting for threads. Wait until the Python thread state of all non-daemon threads get deleted (join all non-daemon threads), rather than just wait until Python threads complete. * Add threading._shutdown_locks: set of Thread._tstate_lock locks of non-daemon threads used by _shutdown() to wait until all Python thread states get deleted. See Thread._set_tstate_lock(). * Add also threading._shutdown_locks_lock to protect access to threading._shutdown_locks. * Add test_finalization_shutdown() test. (cherry picked from commit 468e5fe) Co-authored-by: Victor Stinner <vstinner@redhat.com>
|
I prefer to wait to see how buildbots like PR #13948 merged into master, before merging the backport to 3.8. |
|
@vstinner: Status check is done, and it's a failure ❌ . |
|
the build failure on the azure CI is macOS hanging within thoughts on if this is spurious or related? regardless, i think your change looks good. |
|
It seems like macOS of Azure Pipelines is sick: https://bugs.python.org/issue37245 |
|
me:
Gregory:
It also LGTM but I was right to wait for buildbots: I introduced a giant regression! https://bugs.python.org/issue37265 ... the fix is stupid :-) #14047 I will backport the change manually using my fix. |
Fix a race condition at Python shutdown when waiting for threads.
Wait until the Python thread state of all non-daemon threads get
deleted (join all non-daemon threads), rather than just wait until
Python threads complete.
of non-daemon threads used by _shutdown() to wait until all Python
thread states get deleted. See Thread._set_tstate_lock().
threading._shutdown_locks.
(cherry picked from commit 468e5fe)
Co-authored-by: Victor Stinner vstinner@redhat.com
https://bugs.python.org/issue36402