gh-139951: Test on GC collection disabled if threshold is zero#140304
Merged
markshannon merged 2 commits intoOct 20, 2025
python:mainpython/cpython:mainfrom
efimov-mikhail:gc_threshold_zero_testefimov-mikhail/cpython:gc_threshold_zero_testCopy head branch name to clipboard
Merged
gh-139951: Test on GC collection disabled if threshold is zero#140304markshannon merged 2 commits intopython:mainpython/cpython:mainfrom efimov-mikhail:gc_threshold_zero_testefimov-mikhail/cpython:gc_threshold_zero_testCopy head branch name to clipboard
markshannon merged 2 commits into
python:mainpython/cpython:mainfrom
efimov-mikhail:gc_threshold_zero_testefimov-mikhail/cpython:gc_threshold_zero_testCopy head branch name to clipboard
Conversation
| gc.enable() | ||
|
|
||
| # Ensure that setting *threshold0* to zero disables collection. | ||
| @gc_threshold(0, 0, 0) |
Contributor
There was a problem hiding this comment.
It is better to set gc_threshold(0) to keep other values defaults.
sergey-miryanov
approved these changes
Oct 18, 2025
sergey-miryanov
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Overall, I believe it is worth to add such test.
|
Thanks @efimov-mikhail for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 20, 2025
…ythonGH-140304) (cherry picked from commit 5d0abb6) Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 20, 2025
…ythonGH-140304) (cherry picked from commit 5d0abb6) Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
|
GH-140362 is a backport of this pull request to the 3.14 branch. |
|
GH-140363 is a backport of this pull request to the 3.13 branch. |
|
JelleZijlstra
pushed a commit
that referenced
this pull request
Oct 21, 2025
…GH-140304) (#140363) gh-139951: Test on GC collection disabled if threshold is zero (GH-140304) (cherry picked from commit 5d0abb6) Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
JelleZijlstra
pushed a commit
that referenced
this pull request
Oct 21, 2025
…GH-140304) (#140362) gh-139951: Test on GC collection disabled if threshold is zero (GH-140304) (cherry picked from commit 5d0abb6) Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just adds small test.
I've noticed that there's no such test because CI is green for this PR:
#140262, but it has such a flaw.