python · encukou · Oct 16, 2025 · Oct 16, 2025 · Oct 16, 2025 · efimov-mikhail
@@ -2123,11 +2123,6 @@ typealias_new_impl(PyTypeObject *type, PyObject *name, PyObject *value,
        return NULL;
    }

-    PyObject *module = caller();
-    if (module == NULL) {
-        return NULL;
-    }
-
    if (qualname == NULL || qualname == Py_None) {
        // If qualname was not set directly, we use name instead.
        qualname = name;
@@ -2138,6 +2133,11 @@ typealias_new_impl(PyTypeObject *type, PyObject *name, PyObject *value,
        }
    }

+    PyObject *module = caller();
+    if (module == NULL) {
+        return NULL;
+    }
+
    PyObject *ta = (PyObject *)typealias_alloc(
        name, qualname, checked_params, NULL, value, module);
    Py_DECREF(module);
-Original file line number
+Diff line change
@@ -2123,11 +2123,6 @@ typealias_new_impl(PyTypeObject *type, PyObject *name, PyObject *value,
             return NULL;
         }
-        PyObject *module = caller();
-        if (module == NULL) {
-            return NULL;
-        }
         if (qualname == NULL || qualname == Py_None) {
             // If qualname was not set directly, we use name instead.
             qualname = name;
@@ -2138,6 +2133,11 @@ typealias_new_impl(PyTypeObject *type, PyObject *name, PyObject *value,
             }
         }
         Comment thread


        

        
      

        
          


  
    
        
        
  
    
      
          
      

      
            efimov-mikhail
  

      

      

      


        Oct 16, 2025



      
  •

  
    
      
        
          edited
          
        
        
      
    
    
      
  
        
      Loading


  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  
    
  


    

  

  
    
      
          
    
  


        
            
  
      
              Copy link

  
              
  
      
                Copy Markdown

  
        
      
    

    
        

  
  Member


        

    
  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      IMO, it's better to place obtaining of module after qualname related if-block and remove a call of Py_DECREF(module).
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
              
  
    
    
            encukou reacted with thumbs up emoji
      
        
            
    All reactions
  


          
              
                👍
                  1 reaction
+        PyObject *module = caller();
+        if (module == NULL) {
+            return NULL;
+        }
         PyObject *ta = (PyObject *)typealias_alloc(
             name, qualname, checked_params, NULL, value, module);
         Py_DECREF(module);
-          Expand Down