gh-83714: Check for struct statx.stx_atomic_write_unit_max_opt in configure#140185
gh-83714: Check for struct statx.stx_atomic_write_unit_max_opt in configure#140185vstinner merged 1 commit intopython:mainpython/cpython:mainfrom jbosboom:statx-atomic-write-unit-max-optjbosboom/cpython:statx-atomic-write-unit-max-optCopy head branch name to clipboard
Conversation
stx_atomic_write_unit_max_opt was added in Linux 6.16, but is controlled by the STATX_WRITE_ATOMIC mask bit added in Linux 6.11. That's safe at runtime because all kernels clear the reserved space in struct statx and zero is a valid value for stx_atomic_write_unit_max_opt, and it avoids allocating another mask bit, which are a limited resource. But it also means the kernel headers don't provide a way to check whether stx_atomic_write_unit_max_opt exists, so add a configure check.
|
!buildbot AMD64 CentOS9 NoGIL 3.x |
|
You don't have write permissions to trigger a build |
|
#139178 failed on the AMD64 CentOS9 NoGIL 3.x (tier-1), ARM64 Raspbian Debug 3.x (tier-3) and ARM Raspbian 3.x (tier-3) buildbots. I need someone with the appropriate permissions to run those before merging. This should be skip-news. |
cmaloney
left a comment
There was a problem hiding this comment.
This seems like a reasonable approach to me; a core dev can trigger the bots to validate (although the queue can take a while to get to the top of).
I think skip news works as this is falls under "If a change is a fix (or other adjustment) to an earlier unreleased change and the original NEWS entry remains valid, then no additional entry is needed."
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
|
!buildbot AMD64.CentOS9.NoGIL |
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 37ebb56 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140185%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
vstinner
left a comment
There was a problem hiding this comment.
LGTM, but let me check on buildbots.
|
!buildbot Raspbian |
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit 37ebb56 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140185%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Buildbot issues to expect:
|
|
Buildbots passed successfully:
Alright, AMD64 CentOS9 NoGIL Refleaks PR failed on an unrelated test: |
|
Merged, thanks @jbosboom. |
…in configure (python#140185) stx_atomic_write_unit_max_opt was added in Linux 6.16, but is controlled by the STATX_WRITE_ATOMIC mask bit added in Linux 6.11. That's safe at runtime because all kernels clear the reserved space in struct statx and zero is a valid value for stx_atomic_write_unit_max_opt, and it avoids allocating another mask bit, which are a limited resource. But it also means the kernel headers don't provide a way to check whether stx_atomic_write_unit_max_opt exists, so add a configure check.
stx_atomic_write_unit_max_opt was added in Linux 6.16, but is controlled by the STATX_WRITE_ATOMIC mask bit added in Linux 6.11. That's safe at runtime because all kernels clear the reserved space in struct statx and zero is a valid value for stx_atomic_write_unit_max_opt, and it avoids allocating another mask bit, which are a limited resource. But it also means the kernel headers don't provide a way to check whether stx_atomic_write_unit_max_opt exists, so add a configure check.
I ran
make regen-configure. I know very little about autoconf, so please check I didn't mess up.📚 Documentation preview 📚: https://cpython-previews--140185.org.readthedocs.build/