gh-76007: Deprecate zlib.__version__ attribute#140130
gh-76007: Deprecate zlib.__version__ attribute#140130
zlib.__version__ attribute#140130Conversation
| ZLIB_CRC32_COMBINE_METHODDEF | ||
| ZLIB_DECOMPRESS_METHODDEF | ||
| ZLIB_DECOMPRESSOBJ_METHODDEF | ||
| {"__getattr__", zlib_getattr, METH_VARARGS, "Module __getattr__"}, |
There was a problem hiding this comment.
I tried to convert the function to Argument Clinic, but it failed, oh!
Error in file 'Modules/zlibmodule.c' on line 2019:
'__getattr__' is a special method and cannot be converted to Argument Clinic!
There was a problem hiding this comment.
I tried that too :-)
There was a problem hiding this comment.
Would this be a valid feature request for AC or it’s somehow impossible?
There was a problem hiding this comment.
I tried, and it is relatively straightforward (I based my implementation on METHOD_INIT's), here is a patch. I do not know if there was a reason for this not being done before, other than there not being a need, as it is explicitly in the unsupported list, maybe Victor knows more?
There was a problem hiding this comment.
I have no idea why it's not supported currently.
There was a problem hiding this comment.
What do you think about the patch?
|
Merged, thanks. I also saw that version but forgot to deprecate it :-) |
📚 Documentation preview 📚: https://cpython-previews--140130.org.readthedocs.build/