Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

GH-139979: Add @force_not_colorized_test_class to TestOptionalHelpVersionActions#139980

Merged
savannahostrowski merged 1 commit into
python:mainpython/cpython:mainfrom
savannahostrowski:add-color-decoratorsavannahostrowski/cpython:add-color-decoratorCopy head branch name to clipboard
Oct 12, 2025
Merged

GH-139979: Add @force_not_colorized_test_class to TestOptionalHelpVersionActions#139980
savannahostrowski merged 1 commit into
python:mainpython/cpython:mainfrom
savannahostrowski:add-color-decoratorsavannahostrowski/cpython:add-color-decoratorCopy head branch name to clipboard

Conversation

@savannahostrowski

@savannahostrowski savannahostrowski commented Oct 12, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The TestOptionalsHelpVersionActions test class is missing the @force_not_colorized_test_class decorator, causing test failures when running in terminals with TERM set and stdout as a TTY, as the tests expect plain text output.

I think this was missed in #136809

@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Oct 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 12, 2025
Closed
@savannahostrowski savannahostrowski changed the title GH-139979: Add decorator to prevent color GH-139979: Add @force_not_colorized_test_class to TestOptionalHelpVersionActions Oct 12, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Oct 12, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@savannahostrowski savannahostrowski merged commit 0fc5c56 into python:main Oct 12, 2025
59 checks passed
@miss-islington-app

miss-islington-app Bot commented Oct 12, 2025

Copy link
Copy Markdown

Thanks @savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2025
@savannahostrowski @miss-islington
pythonGH-139979: Add @force_not_colorized_test_class to TestOptionalH…
b9723d0 
…elpVersionActions (pythonGH-139980)

(cherry picked from commit 0fc5c56)

Co-authored-by: Savannah Ostrowski <savannah@python.org>
@bedevere-app

bedevere-app Bot commented Oct 12, 2025

Copy link
Copy Markdown

GH-140005 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 12, 2025
savannahostrowski added a commit that referenced this pull request Oct 12, 2025
@miss-islington @savannahostrowski
[3.14] GH-139979: Add @force_not_colorized_test_class to TestOptional…
11ac373 
…HelpVersionActions (GH-139980) (#140005)

GH-139979: Add @force_not_colorized_test_class to TestOptionalHelpVersionActions (GH-139980)
(cherry picked from commit 0fc5c56)

Co-authored-by: Savannah Ostrowski <savannah@python.org>
@savannahostrowski savannahostrowski deleted the add-color-decorator branch December 4, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@savannahostrowski @hugovk @serhiy-storchaka
Morty Proxy This is a proxified and sanitized view of the page, visit original site.