[WIP] bpo-36402: Fix test_threading.test_threads_join_2()#13946
Closed
vstinner wants to merge 1 commit into
python:masterpython/cpython:masterfrom
vstinner:fix_threads_join_2Copy head branch name to clipboard
Closed
[WIP] bpo-36402: Fix test_threading.test_threads_join_2()#13946vstinner wants to merge 1 commit intopython:masterpython/cpython:masterfrom vstinner:fix_threads_join_2Copy head branch name to clipboard
vstinner wants to merge 1 commit into
python:masterpython/cpython:masterfrom
vstinner:fix_threads_join_2Copy head branch name to clipboard
Conversation
Fix test_threading.test_threads_join_2(): run the test into a subprocess, rather than in a subinterpreter, to avoid a race condition.
Member
Author
|
I'm not sure that this fix is correct. The purpose of the test is to ensure that Py_EndInterpreter() joins properly threads: commit 7b47699. |
Member
Author
|
Nah, this change is plain wrong. https://bugs.python.org/issue36402 is a real bug, this change only hides it. PR #13948 is the good fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test_threading.test_threads_join_2(): run the test into a
subprocess, rather than in a subinterpreter, to avoid a race
condition.
https://bugs.python.org/issue36402