gh-74857, PEP 538: Coerce POSIX locale to UTF-8 based locale#139238
Merged
Merged
gh-74857, PEP 538: Coerce POSIX locale to UTF-8 based locale#139238
Conversation
Member
Author
|
cc @ncoghlan |
ncoghlan
reviewed
Sep 22, 2025
ncoghlan
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, but there's a now-outdated Linux-specific setup clause in the test code that should be removed (we used to only test POSIX on Linux systems, but with it being added to the cross-platform set, we don't need to test it a second time).
Member
Author
|
@ncoghlan: Please review the updated PR. |
Member
Author
|
Merged, thanks for the review @ncoghlan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.