Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-101100: Resolve reference warnings in reference/#138418

Merged
AA-Turner merged 5 commits into
python:mainpython/cpython:mainfrom
AA-Turner:docs/refwarn/datamodelAA-Turner/cpython:docs/refwarn/datamodelCopy head branch name to clipboard
Sep 8, 2025
Merged

gh-101100: Resolve reference warnings in reference/#138418
AA-Turner merged 5 commits into
python:mainpython/cpython:mainfrom
AA-Turner:docs/refwarn/datamodelAA-Turner/cpython:docs/refwarn/datamodelCopy head branch name to clipboard

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Sep 3, 2025

Copy link
Copy Markdown
Member

@AA-Turner AA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 3, 2025
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Sep 3, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Sep 3, 2025
@AA-Turner AA-Turner changed the title Resolve reference warnings in reference/ GH-101100: Resolve reference warnings in reference/ Sep 3, 2025
@AA-Turner AA-Turner marked this pull request as ready for review September 3, 2025 00:27
@AA-Turner AA-Turner marked this pull request as draft September 3, 2025 00:27
@AA-Turner AA-Turner marked this pull request as ready for review September 3, 2025 20:46
@hugovk hugovk changed the title GH-101100: Resolve reference warnings in reference/ gh-101100: Resolve reference warnings in reference/ Sep 8, 2025
@hugovk

hugovk commented Sep 8, 2025

Copy link
Copy Markdown
Member

@hugovk changed the title
GH-101100: Resolve reference warnings in reference/
gh-101100: Resolve reference warnings in reference/

The convention is gh for issues and GH for PRs :)

Here “gh-12345” is the GitHub issue number, and “GH-NNNN” is the number of the original pull request.

https://devguide.python.org/core-team/committing/#backporting-changes-to-an-older-version

Comment thread Doc/reference/datamodel.rst Outdated
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@AA-Turner AA-Turner enabled auto-merge (squash) September 8, 2025 19:25
@AA-Turner AA-Turner merged commit 6831634 into python:main Sep 8, 2025
27 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Sep 8, 2025
@miss-islington-app

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 8, 2025
…38418)

(cherry picked from commit 6831634)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 8, 2025
…38418)

(cherry picked from commit 6831634)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Sep 8, 2025

Copy link
Copy Markdown

GH-138680 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 8, 2025
@bedevere-app

bedevere-app Bot commented Sep 8, 2025

Copy link
Copy Markdown

GH-138681 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 8, 2025
@AA-Turner AA-Turner deleted the docs/refwarn/datamodel branch September 8, 2025 19:51
hugovk pushed a commit that referenced this pull request Sep 9, 2025
#138680)

gh-101100: Resolve reference warnings in reference/ (GH-138418)
(cherry picked from commit 6831634)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
pablogsal pushed a commit that referenced this pull request Feb 15, 2026
#138681)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <stan@ulbrych.org>
encukou added a commit that referenced this pull request May 14, 2026
In gh-138418, `!` was added to links to rules that don't exist in
the docs, in order to silence broken link warnings.
However, productionlist doesn't parse the `!`, which ends up in
the rendered documentation. (It's possible that gh-127835 broke
the `!` support.)

Replace the names with ones that appear in docs:

- `star_named_expression` in the grammar corresponds to
  `flexible_expression` in the docs
- `star_named_expressions` in the grammar corresponds to
  `flexible_expression_list` in the docs
- `named_expression` in the grammar corresponds to
  `assignment_expression` in the docs

Having two sets of names isn't great of course. Consolidating them
is tracked in (subissues of) gh-127833.
encukou added a commit that referenced this pull request May 14, 2026
…49836)

Link to existing rules in compound_stmts.rst (GH-149811)

In gh-138418, `!` was added to links to rules that don't exist in
the docs, in order to silence broken link warnings.
However, productionlist doesn't parse the `!`, which ends up in
the rendered documentation. (It's possible that gh-127835 broke
the `!` support.)

Replace the names with ones that appear in docs:

- `star_named_expression` in the grammar corresponds to
  `flexible_expression` in the docs
- `star_named_expressions` in the grammar corresponds to
  `flexible_expression_list` in the docs
- `named_expression` in the grammar corresponds to
  `assignment_expression` in the docs

Having two sets of names isn't great of course. Consolidating them
is tracked in (subissues of) gh-127833.
(cherry picked from commit c375292)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this pull request May 14, 2026
…49837)

Link to existing rules in compound_stmts.rst (GH-149811)

In gh-138418, `!` was added to links to rules that don't exist in
the docs, in order to silence broken link warnings.
However, productionlist doesn't parse the `!`, which ends up in
the rendered documentation. (It's possible that gh-127835 broke
the `!` support.)

Replace the names with ones that appear in docs:

- `star_named_expression` in the grammar corresponds to
  `flexible_expression` in the docs
- `star_named_expressions` in the grammar corresponds to
  `flexible_expression_list` in the docs
- `named_expression` in the grammar corresponds to
  `assignment_expression` in the docs

Having two sets of names isn't great of course. Consolidating them
is tracked in (subissues of) gh-127833.
(cherry picked from commit c375292)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this pull request May 14, 2026
…49838)

Link to existing rules in compound_stmts.rst (GH-149811)

In gh-138418, `!` was added to links to rules that don't exist in
the docs, in order to silence broken link warnings.
However, productionlist doesn't parse the `!`, which ends up in
the rendered documentation. (It's possible that gh-127835 broke
the `!` support.)

Replace the names with ones that appear in docs:

- `star_named_expression` in the grammar corresponds to
  `flexible_expression` in the docs
- `star_named_expressions` in the grammar corresponds to
  `flexible_expression_list` in the docs
- `named_expression` in the grammar corresponds to
  `assignment_expression` in the docs

Having two sets of names isn't great of course. Consolidating them
is tracked in (subissues of) gh-127833.
(cherry picked from commit c375292)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.