gh-137571: Fix UnboundLocalError in gzip._GzipReader.read()#137572
Closed
maurycy wants to merge 2 commits into
Closed
gh-137571: Fix UnboundLocalError in gzip._GzipReader.read()#137572maurycy wants to merge 2 commits into
UnboundLocalError in gzip._GzipReader.read()#137572maurycy wants to merge 2 commits into
Conversation
UnboundLocalError in gzip._GzipReader.read()UnboundLocalError in gzip._GzipReader.read()
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
This may change the behavior. Before, the error was raised only if both uncompress and buf are empty. Now it is raised without an attempt to decompress.
Contributor
Author
|
6 months passed; stale. |
Member
Contributor
Author
|
@serhiy-storchaka Thank you for picking this up. You're right, and #150222 is a cleaner fix. Apologies for letting this go on my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much more detailed description, including the reproduction steps, in the issue.
I'm not 100% sure about the fix. The easiest is just a sentinel (
buf = None).gzip._GzipReader.read()with sometimes uninitialized variable #137571