bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall().#13714
Merged
ericsnowcurrently merged 20 commits intoJun 1, 2019
python:masterpython/cpython:masterfrom
ericsnowcurrently:pending-calls-unrevertericsnowcurrently/cpython:pending-calls-unrevertCopy head branch name to clipboard
Merged
bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall().#13714ericsnowcurrently merged 20 commits intopython:masterpython/cpython:masterfrom ericsnowcurrently:pending-calls-unrevertericsnowcurrently/cpython:pending-calls-unrevertCopy head branch name to clipboard
ericsnowcurrently merged 20 commits into
python:masterpython/cpython:masterfrom
ericsnowcurrently:pending-calls-unrevertericsnowcurrently/cpython:pending-calls-unrevertCopy head branch name to clipboard
Conversation
Contributor
|
Looks like the Mac CI's hate you now. 😉 |
vstinner
added a commit
that referenced
this pull request
Jun 3, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…ngCall(). (pythongh-13714)" (pythonGH-13780) This reverts commit 6a150bc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 different bugs in the original PRs and have fixed them here.
I also tried again (with some tweaks) in #12360, which I ended up reverting in #12806. For this attempt I am dropping the code that calls any remaining pending calls during runtime finalization. We'll see if the FreeBSD buildbot still hates me. :)
https://bugs.python.org/issue33608