gh-136710: posixmodule.c: fix `chdir` docstring by haampie · Pull Request #136709 · python/cpython

haampie · Jul 16, 2025

Fixes the following issue:

>>> from docutils.core import publish_doctree
>>> from posix import chdir
>>> publish_doctree(chdir.__doc__)
<string>:5: (ERROR/3) Unexpected indentation.

Issue: os.chdir docstring is invalid rst #136710

Fixes the following issue: ``` >>> from docutils.core import publish_doctree >>> from posix import chdir >>> publish_doctree(chdir.__doc__) <string>:5: (ERROR/3) Unexpected indentation. ```

kailando · Jul 16, 2025

Hmm... You may have to update it.

At Tests / Check if generated files are up to date (pull_request):

Generated files not up to date.
Perhaps you forgot to run make regen-all or build.bat --regen. ;)
configure files must be regenerated with a specific version of autoconf.
M  Modules/clinic/posixmodule.c.h
M  Modules/posixmodule.c

diff --git a/Modules/clinic/posixmodule.c.h b/Modules/clinic/posixmodule.c.h
index 22f426c..65f5f8c 100644
--- a/Modules/clinic/posixmodule.c.h
+++ b/Modules/clinic/posixmodule.c.h
@@ -380,7 +380,7 @@ PyDoc_STRVAR(os_chdir__doc__,
 "\n"
 "path may always be specified as a string.\n"
 "On some platforms, path may also be specified as an open file descriptor.\n"
-"  If this functionality is unavailable, using it raises an exception.");
+"If this functionality is unavailable, using it raises an exception.");
 
 #define OS_CHDIR_METHODDEF    \
     {"chdir", _PyCFunction_CAST(os_chdir), METH_FASTCALL|METH_KEYWORDS, os_chdir__doc__},
@@ -13440,4 +13440,4 @@ os__emscripten_debugger(PyObject *module, PyObject *Py_UNUSED(ignored))
 #ifndef OS__EMSCRIPTEN_DEBUGGER_METHODDEF
     #define OS__EMSCRIPTEN_DEBUGGER_METHODDEF
 #endif /* !defined(OS__EMSCRIPTEN_DEBUGGER_METHODDEF) */
-/*[clinic end generated code: output=5341daae6581a62b input=a9049054013a1b77]*/
+/*[clinic end generated code: output=6cfddb3b77dc7a40 input=a9049054013a1b77]*/
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 66baa1a..47eaf5c 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -3482,7 +3482,7 @@ If this functionality is unavailable, using it raises an exception.
 
 static PyObject *
 os_chdir_impl(PyObject *module, path_t *path)
-/*[clinic end generated code: output=3be6400eee26eaae input=1a4a15b4d12cb15d]*/
+/*[clinic end generated code: output=3be6400eee26eaae input=a74ceab5d72adf74]*/
 {
     int result;
 
Error: Process completed with exhttps://github.com/python/cpython/actions/runs/16320837703/job/46097908962?pr=136709it code 1.

This reverts commit ea6d10b.

Misc/NEWS.d/next/Documentation/2025-07-16-13-28-30.gh-issue-136710.NrGnSZ.rst

Modules/posixmodule.c

haampie · Jul 16, 2025

thanks for directly pushing

miss-islington-app · Jul 16, 2025

Thanks @haampie for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington-app · Jul 16, 2025

Sorry, @haampie and @zware, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bde808ad6ba5eee8a6201983cf071449d7ce7e39 3.14

miss-islington-app · Jul 16, 2025

Sorry, @haampie and @zware, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bde808ad6ba5eee8a6201983cf071449d7ce7e39 3.13

…ythonGH-136709) (cherry picked from commit bde808a) Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>

…H-136709)

Fixes: Checking branch 3.13 From https://github.com/python/cpython * [new branch] 3.13 -> 3.13 1 1 10000 python/cpython#136930 gh-136914: Fix support of cached functions and properties in DocTest's lineno computation (GH-136930) Backport to 3.13 missing 2 1 10000 python/cpython#136890 Fix typos in Doc/extending/extending.rst and Doc/library/shelve.rst (GH-136890) Backport to 3.13 missing 3 1 10000 python/cpython#136709 gh-136710: Fix bad indentation in `os.chdir` docstring (GH-136709) Backport to 3.13 missing 4 1 10000 python/cpython#136519 Omit `Python/perf_jit_trampoline.c` from the `**/*jit*` CODEOWNERS rule (#136519) fatal: command line, 'Omit `Python/perf_jit_trampoline.c` from the `**/*jit*` CODEOWNERS rule (#136519)': Invalid preceding regular expression Traceback (most recent call last): File "/home/runner/work/dashboard/dashboard/github-tools/needs_backport.py", line 214, in <module> main() ~~~~^^ File "/home/runner/work/dashboard/dashboard/github-tools/needs_backport.py", line 170, in main candidates = check_prs( api, args.repo_path, branch, args.start, args.number, args.sort ) File "/home/runner/work/dashboard/dashboard/github-tools/needs_backport.py", line 109, in check_prs if is_commit_title_in_branch(repo_path, title, branch_to_check): ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/runner/work/dashboard/dashboard/github-tools/needs_backport.py", line 60, in is_commit_title_in_branch output = subprocess.check_output( ~~~~~~~~~~~~~~~~~~~~~~~^ ["git", "log", "--grep", title, branch], cwd=repo_path ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ).decode("utf-8") ^ File "/opt/hostedtoolcache/Python/3.13.5/x64/lib/python3.13/subprocess.py", line 472, in check_output return run(*popenargs, stdout=PIPE, timeout=timeout, check=True, ~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ **kwargs).stdout ^^^^^^^^^ File "/opt/hostedtoolcache/Python/3.13.5/x64/lib/python3.13/subprocess.py", line 577, in run raise CalledProcessError(retcode, process.args, output=stdout, stderr=stderr) subprocess.CalledProcessError: Command '['git', 'log', '--grep', 'Omit `Python/perf_jit_trampoline.c` from the `**/*jit*` CODEOWNERS rule (#136519)', '3.13']' returned non-zero exit status 128.

miss-islington-app · Aug 10, 2025

Thanks @haampie for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · Aug 10, 2025

Thanks @haampie for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app · Aug 10, 2025

Sorry, @haampie and @zware, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bde808ad6ba5eee8a6201983cf071449d7ce7e39 3.13

miss-islington-app · Aug 10, 2025

Sorry, @haampie and @zware, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bde808ad6ba5eee8a6201983cf071449d7ce7e39 3.14

…H-136709)

posixmodule.c: fix chdir docstring

7bbd568

Fixes the following issue: ``` >>> from docutils.core import publish_doctree >>> from posix import chdir >>> publish_doctree(chdir.__doc__) <string>:5: (ERROR/3) Unexpected indentation. ```

bedevere-app bot added the awaiting review label Jul 16, 2025

haampie changed the title ~~posixmodule.c: fix chdir docstring~~ gh-136710: posixmodule.c: fix chdir docstring Jul 16, 2025

bedevere-app bot mentioned this pull request Jul 16, 2025

os.chdir docstring is invalid rst #136710

Closed

📜🤖 Added by blurb_it.

ea6d10b

haampie mentioned this pull request Jul 16, 2025

spack.package: add to docs, drop re-exports spack/spack#51006

Merged

zware added 2 commits July 16, 2025 10:00

Revert "📜🤖 Added by blurb_it."

ba192b7

This reverts commit ea6d10b.

make clinic

058abcd

zware added the skip news label Jul 16, 2025

zware reviewed Jul 16, 2025

View reviewed changes

Misc/NEWS.d/next/Documentation/2025-07-16-13-28-30.gh-issue-136710.NrGnSZ.rst Outdated Show resolved Hide resolved

Modules/posixmodule.c Show resolved Hide resolved

zware enabled auto-merge (squash) July 16, 2025 15:04

zware added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 16, 2025

zware merged commit bde808a into python:main Jul 16, 2025
44 checks passed

bedevere-app bot removed the awaiting review label Jul 16, 2025

miss-islington-app bot assigned zware Jul 16, 2025

zware pushed a commit to zware/cpython that referenced this pull request Jul 16, 2025

[3.14] pythongh-136710: Fix bad indentation in os.chdir docstring (p…

826760f

…ythonGH-136709) (cherry picked from commit bde808a) Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>

zware pushed a commit to zware/cpython that referenced this pull request Jul 16, 2025

[3.13] pythongh-136710: Fix bad indentation in os.chdir docstring (p…

f852f40

…ythonGH-136709) (cherry picked from commit bde808a) Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>

haampie deleted the patch-1 branch July 16, 2025 16:42

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025

pythongh-136710: Fix bad indentation in os.chdir docstring (pythonG…

906b4ae

…H-136709)

serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 10, 2025

serhiy-storchaka removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 10, 2025

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025

pythongh-136710: Fix bad indentation in os.chdir docstring (pythonG…

81180ad

…H-136709)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-136710: posixmodule.c: fix `chdir` docstring#136709

gh-136710: posixmodule.c: fix `chdir` docstring#136709
zware merged 4 commits intopython:mainpython/cpython:mainfrom
haampie:patch-1haampie/cpython:patch-1Copy head branch name to clipboard

haampie commented Jul 16, 2025 •

edited by bedevere-app bot

Loading

Uh oh!

kailando commented Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

haampie commented Jul 16, 2025

Uh oh!

Uh oh!

miss-islington-app bot commented Jul 16, 2025

Uh oh!

miss-islington-app bot commented Jul 16, 2025

Uh oh!

miss-islington-app bot commented Jul 16, 2025

Uh oh!

miss-islington-app bot commented Aug 10, 2025

Uh oh!

miss-islington-app bot commented Aug 10, 2025

Uh oh!

miss-islington-app bot commented Aug 10, 2025

Uh oh!

miss-islington-app bot commented Aug 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

haampie commented Jul 16, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kailando commented Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

haampie commented Jul 16, 2025

Uh oh!

Uh oh!

miss-islington-app bot commented Jul 16, 2025

Uh oh!

miss-islington-app bot commented Jul 16, 2025

Uh oh!

miss-islington-app bot commented Jul 16, 2025

Uh oh!

miss-islington-app bot commented Aug 10, 2025

Uh oh!

miss-islington-app bot commented Aug 10, 2025

Uh oh!

miss-islington-app bot commented Aug 10, 2025

Uh oh!

miss-islington-app bot commented Aug 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

haampie commented Jul 16, 2025 •

edited by bedevere-app bot

Loading