Omit Python/perf_jit_trampoline.c from the **/*jit* CODEOWNERS rule#136519
Merged
pablogsal merged 1 commit intopython:mainpython/cpython:mainfrom Jul 10, 2025
Merged
Omit Python/perf_jit_trampoline.c from the **/*jit* CODEOWNERS rule#136519pablogsal merged 1 commit intopython:mainpython/cpython:mainfrom
Python/perf_jit_trampoline.c from the **/*jit* CODEOWNERS rule#136519pablogsal merged 1 commit intopython:mainpython/cpython:mainfrom
Conversation
StanFromIreland
approved these changes
Jul 10, 2025
Member
StanFromIreland
left a comment
There was a problem hiding this comment.
It should work, this does:
Line 173 in 59acdba
|
Thanks @brandtbucher for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @brandtbucher and @pablogsal, I could not cleanly backport this to |
|
Sorry, @brandtbucher and @pablogsal, I could not cleanly backport this to |
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
…le (python#136519) Omit perf_jit_trampoline from "JIT" codeowners
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…le (python#136519) Omit perf_jit_trampoline from "JIT" codeowners
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
…le (python#136519) Omit perf_jit_trampoline from "JIT" codeowners
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…le (python#136519) Omit perf_jit_trampoline from "JIT" codeowners
hugovk
added a commit
to hugovk/github-tools
that referenced
this pull request
Aug 7, 2025
Fixes: Checking branch 3.13 From https://github.com/python/cpython * [new branch] 3.13 -> 3.13 1 1 10000 python/cpython#136930 gh-136914: Fix support of cached functions and properties in DocTest's lineno computation (GH-136930) Backport to 3.13 missing 2 1 10000 python/cpython#136890 Fix typos in Doc/extending/extending.rst and Doc/library/shelve.rst (GH-136890) Backport to 3.13 missing 3 1 10000 python/cpython#136709 gh-136710: Fix bad indentation in `os.chdir` docstring (GH-136709) Backport to 3.13 missing 4 1 10000 python/cpython#136519 Omit `Python/perf_jit_trampoline.c` from the `**/*jit*` CODEOWNERS rule (#136519) fatal: command line, 'Omit `Python/perf_jit_trampoline.c` from the `**/*jit*` CODEOWNERS rule (#136519)': Invalid preceding regular expression Traceback (most recent call last): File "/home/runner/work/dashboard/dashboard/github-tools/needs_backport.py", line 214, in <module> main() ~~~~^^ File "/home/runner/work/dashboard/dashboard/github-tools/needs_backport.py", line 170, in main candidates = check_prs( api, args.repo_path, branch, args.start, args.number, args.sort ) File "/home/runner/work/dashboard/dashboard/github-tools/needs_backport.py", line 109, in check_prs if is_commit_title_in_branch(repo_path, title, branch_to_check): ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/runner/work/dashboard/dashboard/github-tools/needs_backport.py", line 60, in is_commit_title_in_branch output = subprocess.check_output( ~~~~~~~~~~~~~~~~~~~~~~~^ ["git", "log", "--grep", title, branch], cwd=repo_path ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ).decode("utf-8") ^ File "/opt/hostedtoolcache/Python/3.13.5/x64/lib/python3.13/subprocess.py", line 472, in check_output return run(*popenargs, stdout=PIPE, timeout=timeout, check=True, ~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ **kwargs).stdout ^^^^^^^^^ File "/opt/hostedtoolcache/Python/3.13.5/x64/lib/python3.13/subprocess.py", line 577, in run raise CalledProcessError(retcode, process.args, output=stdout, stderr=stderr) subprocess.CalledProcessError: Command '['git', 'log', '--grep', 'Omit `Python/perf_jit_trampoline.c` from the `**/*jit*` CODEOWNERS rule (#136519)', '3.13']' returned non-zero exit status 128.
|
Thanks @brandtbucher for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @brandtbucher for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @brandtbucher and @pablogsal, I could not cleanly backport this to |
|
Sorry, @brandtbucher and @pablogsal, I could not cleanly backport this to |
Member
|
Reminder about backporting. @brandtbucher @pablogsal |
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…le (python#136519) Omit perf_jit_trampoline from "JIT" codeowners
|
GH-140987 is a backport of this pull request to the 3.14 branch. |
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Nov 4, 2025
…NERS rule (pythonGH-136519) Omit perf_jit_trampoline from "JIT" codeowners (cherry picked from commit 56c6f04) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Nov 4, 2025
…NERS rule (pythonGH-136519) Omit perf_jit_trampoline from "JIT" codeowners (cherry picked from commit 56c6f04) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
|
GH-140988 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this works the way I'm intending?
@pablogsal, let me know if you (or anyone else) belongs on this line.