gh-135552: Don't clear weakref if wr_object is a type.#136151
Closed
nascheme wants to merge 1 commit into
python:mainpython/cpython:mainfrom
nascheme:gh-135552-no-clear-weakrefnascheme/cpython:gh-135552-no-clear-weakrefCopy head branch name to clipboard
Closed
gh-135552: Don't clear weakref if wr_object is a type.#136151nascheme wants to merge 1 commit intopython:mainpython/cpython:mainfrom nascheme:gh-135552-no-clear-weakrefnascheme/cpython:gh-135552-no-clear-weakrefCopy head branch name to clipboard
nascheme wants to merge 1 commit into
python:mainpython/cpython:mainfrom
nascheme:gh-135552-no-clear-weakrefnascheme/cpython:gh-135552-no-clear-weakrefCopy head branch name to clipboard
Conversation
Member
Author
|
I don't think this is safe actually, could introduce bugs like bpo-38006. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at making a fix that could be backported to old Python versions. In
main, I think the best fix is to stop clearing all weakrefs in the GC. However, that seems disruptive enough that we should avoid doing so in a bugfix release. This version of the fix doesn't clear ifwr_objectis a type andwr_callback == NULL. There is still a small chance this would break some code that expects that weakrefs are cleared by the GC. In the unit test suite, we hadtest_finalization,test_ioandtest_gcthat was broken by not clearing weakrefs.