gh-135237: fix setUp/tearDown of _colorize.can_colorize in test_argparse#135238
Closed
tpburns wants to merge 1 commit into
python:mainpython/cpython:mainfrom
tpburns:argparseCanColorizeSafetytpburns/cpython:argparseCanColorizeSafetyCopy head branch name to clipboard
Closed
gh-135237: fix setUp/tearDown of _colorize.can_colorize in test_argparse#135238tpburns wants to merge 1 commit intopython:mainpython/cpython:mainfrom tpburns:argparseCanColorizeSafetytpburns/cpython:argparseCanColorizeSafetyCopy head branch name to clipboard
setUp/tearDown of _colorize.can_colorize in test_argparse#135238tpburns wants to merge 1 commit into
python:mainpython/cpython:mainfrom
tpburns:argparseCanColorizeSafetytpburns/cpython:argparseCanColorizeSafetyCopy head branch name to clipboard
Conversation
sobolevn
approved these changes
Jun 7, 2025
setUp/tearDown of _colorize.can_colorize in test_argparse
|
🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit e27c90b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135238%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
ZeroIntensity
approved these changes
Jun 9, 2025
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
Buildbot failures are unrelated
Member
|
Closing re: #135237 (comment) Thanks anyway! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
test_regrtestTestColorizedandtest_pdbPdbTestColorizefor similar tests with safe setups.cpython/Lib/test/test_regrtest.py
Lines 2577 to 2580 in 24069fb
cpython/Lib/test/test_pdb.py
Lines 4694 to 4701 in 24069fb