Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-133300: argparse: make suggest_on_error a keyword-only parameter#133302

Merged
hugovk merged 1 commit into
python:mainpython/cpython:mainfrom
hugovk:3.14-argparse-keywordhugovk/cpython:3.14-argparse-keywordCopy head branch name to clipboard
May 2, 2025
Merged

gh-133300: argparse: make suggest_on_error a keyword-only parameter#133302
hugovk merged 1 commit into
python:mainpython/cpython:mainfrom
hugovk:3.14-argparse-keywordhugovk/cpython:3.14-argparse-keywordCopy head branch name to clipboard

Conversation

@hugovk

@hugovk hugovk commented May 2, 2025

Copy link
Copy Markdown
Member

@tomasr8 tomasr8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! suggest_on_error is new in 3.14 so we can safely make this change.

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hugovk hugovk merged commit e6c518d into python:main May 2, 2025
45 of 48 checks passed
@hugovk hugovk deleted the 3.14-argparse-keyword branch May 2, 2025 15:11
JelleZijlstra added a commit to python/typeshed that referenced this pull request May 12, 2025
…13947)

These are

- `suggest_on_error`, added by python/cpython#124456, made keyword-only by python/cpython#133302
- `color`, added by python/cpython#132323

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
mmingyu pushed a commit to mmingyu/typeshed that referenced this pull request May 16, 2025
…ython#13947)

These are

- `suggest_on_error`, added by python/cpython#124456, made keyword-only by python/cpython#133302
- `color`, added by python/cpython#132323

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.