Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-132747: Fix NULL dereference when calling a method's __get__ manually #132772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2025
Merged

gh-132747: Fix NULL dereference when calling a method's __get__ manually #132772

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ebcb057
Boy oh boy do I love null dereferences
ZeroIntensity Apr 21, 2025
b9b4fa2
Add simple test.
ZeroIntensity Apr 21, 2025
ad71a50
Fix the test.
ZeroIntensity Apr 21, 2025
9dff963
Add blurb.
ZeroIntensity Apr 21, 2025
c0563c2
Add an assertion.
ZeroIntensity Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Boy oh boy do I love null dereferences
  • Loading branch information
@ZeroIntensity
ZeroIntensity committed Apr 21, 2025
commit ebcb0575343e1767e89abc10fb68a2a6925c1b15
2 changes: 1 addition & 1 deletion 2 Objects/descrobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ method_get(PyObject *self, PyObject *obj, PyObject *type)
return NULL;
}
if (descr->d_method->ml_flags & METH_METHOD) {
if (PyType_Check(type)) {
if (type == NULL || PyType_Check(type)) {
return PyCMethod_New(descr->d_method, obj, NULL, descr->d_common.d_type);
} else {
PyErr_Format(PyExc_TypeError,
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.