Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-132747: Fix NULL dereference when calling a method's __get__ manually #132772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add simple test.
  • Loading branch information
ZeroIntensity committed Apr 21, 2025
commit b9b4fa22e6966ada1cdf72f8f7b5feb8575e5350
18 changes: 18 additions & 0 deletions 18 Lib/test/test_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,24 @@ def test_method_descriptor_types(self):
self.assertIsInstance(int.from_bytes, types.BuiltinMethodType)
self.assertIsInstance(int.__new__, types.BuiltinMethodType)

def test_method_descriptor_crash(self):
# gh-132747: The default __get__() implementation in C was unable
# to handle a second argument of None when called from Python
import _io
import io
import _queue

types = [
# (method, instance)
(_io.TextIOWrapper.write, io.StringIO()),
(_queue.SimpleQueue.put, _queue.SimpleQueue()),
(str.capitalize, "nobody expects the spanish inquisition")
]

for method, instance in types:
with self.subTest(method=method, instance=instance):
method.__get__(instance)

def test_ellipsis_type(self):
self.assertIsInstance(Ellipsis, types.EllipsisType)

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.