Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-36818: Add PyInterpreterState.runtime field.#13129

Merged
ericsnowcurrently merged 4 commits into
python:masterpython/cpython:masterfrom
ericsnowcurrently:interp-runtime-fieldericsnowcurrently/cpython:interp-runtime-fieldCopy head branch name to clipboard
Jun 1, 2019
Merged

bpo-36818: Add PyInterpreterState.runtime field.#13129
ericsnowcurrently merged 4 commits into
python:masterpython/cpython:masterfrom
ericsnowcurrently:interp-runtime-fieldericsnowcurrently/cpython:interp-runtime-fieldCopy head branch name to clipboard

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 6, 2019

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with the overall approach. Maybe I misunderstood you.
https://bugs.python.org/issue36818#msg342043

Comment thread Include/internal/pycore_object.h Outdated
Comment thread Include/internal/pycore_pystate.h Outdated
@bedevere-bot

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be poked with soft cushions!

@vstinner

Copy link
Copy Markdown
Member

Eric is working on a different approach: https://bugs.python.org/issue36854

@ericsnowcurrently

Copy link
Copy Markdown
Member Author

The GC stuff is orthogonal to adding PyInterpreterState.runtime. I still plan on merging this after resolving merge conflicts and any feedback.

@ericsnowcurrently

ericsnowcurrently commented Jun 1, 2019

Copy link
Copy Markdown
Member Author

FYI, I've trimmed the PR down. The changes I've removed can wait until later.

@ericsnowcurrently ericsnowcurrently merged commit 396e0a8 into python:master Jun 1, 2019
@ericsnowcurrently ericsnowcurrently deleted the interp-runtime-field branch June 1, 2019 03:16
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.