GH-125174: Make immortality "sticky"#131184
Merged
markshannon merged 3 commits intoMar 13, 2025
python:mainpython/cpython:mainfrom
faster-cpython:immortal-stickinessfaster-cpython/cpython:immortal-stickinessCopy head branch name to clipboard
Merged
GH-125174: Make immortality "sticky"#131184markshannon merged 3 commits intopython:mainpython/cpython:mainfrom faster-cpython:immortal-stickinessfaster-cpython/cpython:immortal-stickinessCopy head branch name to clipboard
markshannon merged 3 commits into
python:mainpython/cpython:mainfrom
faster-cpython:immortal-stickinessfaster-cpython/cpython:immortal-stickinessCopy head branch name to clipboard
Conversation
iritkatriel
approved these changes
Mar 13, 2025
Member
|
This broke refleak buildbots. |
markshannon
added a commit
to faster-cpython/cpython
that referenced
this pull request
Mar 14, 2025
This reverts commit 3a91ee9.
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
…ython#131230) Revert "pythonGH-125174: Make immortality "sticky" (pythonGH-131184)" This reverts commit 3a91ee9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make immortality "sticky" by increasing the threshold for immortality in increfs, but leaving it the same for decrefs.
This way, no object will ever see more decrefs than increfs. Immortal objects may see more increfs than decrefs, but that's not a problem.
Performance is neutral.