Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-36748: optimize TextIOWrapper.write() for ASCII string#13002

Merged
methane merged 4 commits into
python:masterpython/cpython:masterfrom
methane:opt-textio-2methane/cpython:opt-textio-2Copy head branch name to clipboard
May 16, 2019
Merged

bpo-36748: optimize TextIOWrapper.write() for ASCII string#13002
methane merged 4 commits into
python:masterpython/cpython:masterfrom
methane:opt-textio-2methane/cpython:opt-textio-2Copy head branch name to clipboard

Conversation

@methane

@methane methane commented Apr 29, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@methane methane added the performance Performance or resource usage label Apr 29, 2019
@ZackerySpytz

ZackerySpytz commented May 6, 2019

Copy link
Copy Markdown
Contributor

I tested this PR locally, and it seems that there are reference leaks (according to ./python -m test -R 3:3 test_io).

test_io leaked [4, 4, 4] references, sum=12
test_io failed in 4 min 12 sec

== Tests result: FAILURE ==

1 test failed:
    test_io

Total duration: 4 min 12 sec
Tests result: FAILURE

@methane methane changed the title bpo-36748: optimize textio write buffering bpo-36748: optimize TextIOWrapper.write() for ASCII string May 16, 2019
@methane methane merged commit bfba8c3 into python:master May 16, 2019
@methane methane deleted the opt-textio-2 branch May 16, 2019 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane @ZackerySpytz @the-knights-who-say-ni @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.