Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fixes platform.win32_ver on non-Windows platforms#12912

Merged
zooba merged 1 commit into
python:masterpython/cpython:masterfrom
zooba:platform-fixzooba/cpython:platform-fixCopy head branch name to clipboard
Apr 22, 2019
Merged

Fixes platform.win32_ver on non-Windows platforms#12912
zooba merged 1 commit into
python:masterpython/cpython:masterfrom
zooba:platform-fixzooba/cpython:platform-fixCopy head branch name to clipboard

Conversation

@zooba

@zooba zooba commented Apr 22, 2019

Copy link
Copy Markdown
Member

No description provided.

@zooba

zooba commented Apr 22, 2019

Copy link
Copy Markdown
Member Author

I spotted this issue on #11774 which adds some extra calls to this function in tests. We shouldn't be letting the ImportError escape regardless.

@zooba zooba merged commit d307d05 into python:master Apr 22, 2019
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@zooba zooba deleted the platform-fix branch April 22, 2019 18:40
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 22, 2019
(cherry picked from commit d307d05)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@bedevere-bot

Copy link
Copy Markdown

GH-12913 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Apr 22, 2019
(cherry picked from commit d307d05)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.