-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-127691: add type checks when using PyUnicodeError
objects
#127694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
bd07ea4
add type checks when using `PyUnicodeError` objects
picnixz 21bcef2
reduce un-necessary casts
picnixz 17d2665
fix check
picnixz bac5031
fix tests
picnixz 37655a2
blurb
picnixz af7e7bb
fix typo
picnixz a8bfd70
fix refs
picnixz 0ec814e
Update CHANGELOG
picnixz 7c7d20c
Apply suggestions from code review
picnixz 49a32cf
Update Objects/exceptions.c
picnixz a5ee3d0
Update Objects/exceptions.c
picnixz 7fe6e67
Fix English
picnixz 970720a
Improve wording
picnixz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
The :ref:`Unicode Exception Objects <unicodeexceptions>` C API | ||
now raises :exc:`TypeError` if its exception argument is not an | ||
picnixz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
:exc:`UnicodeError`. Patch by Bénédikt Tran. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.