Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-127691: add type checks when using PyUnicodeError objects #127694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 13, 2024
Merged

gh-127691: add type checks when using PyUnicodeError objects #127694

merged 13 commits into from
Dec 13, 2024

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Dec 6, 2024 •
edited by bedevere-app bot
Loading

I think there will be CI failures so I'll fix them when the CI completes.

@bedevere-app bedevere-app bot mentioned this pull request Dec 6, 2024
Closed
@picnixz picnixz marked this pull request as ready for review December 6, 2024 16:07
@picnixz picnixz requested a review from iritkatriel as a code owner December 6, 2024 16:07
@picnixz picnixz requested a review from encukou December 6, 2024 16:22
ZeroIntensity
ZeroIntensity reviewed Dec 6, 2024
View reviewed changes
Objects/exceptions.c Show resolved Hide resolved
@ZeroIntensity
Copy link
Member

Will do a thorough review after I finish reviewing a few other things :)

ZeroIntensity
ZeroIntensity reviewed Dec 7, 2024
View reviewed changes
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Objects/exceptions.c Outdated Show resolved Hide resolved
Objects/exceptions.c Outdated Show resolved Hide resolved
Objects/exceptions.c Show resolved Hide resolved
Objects/exceptions.c Show resolved Hide resolved
Objects/exceptions.c Outdated Show resolved Hide resolved
picnixz
picnixz commented Dec 7, 2024
View reviewed changes
Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst Outdated Show resolved Hide resolved
Objects/exceptions.c Outdated Show resolved Hide resolved
Objects/exceptions.c Outdated Show resolved Hide resolved
Objects/exceptions.c Show resolved Hide resolved
Objects/exceptions.c Outdated Show resolved Hide resolved
picnixz
picnixz commented Dec 7, 2024
View reviewed changes
Objects/exceptions.c Outdated Show resolved Hide resolved
picnixz
picnixz commented Dec 7, 2024
View reviewed changes
Objects/exceptions.c Outdated Show resolved Hide resolved
picnixz
picnixz commented Dec 7, 2024
View reviewed changes
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst Outdated Show resolved Hide resolved
picnixz
picnixz commented Dec 7, 2024
View reviewed changes
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst Outdated Show resolved Hide resolved
This was referenced Dec 10, 2024
Closed
Merged
@encukou encukou merged commit 8bc1818 into python:main Dec 13, 2024
41 checks passed
@encukou
Copy link
Member

encukou commented Dec 13, 2024

Thank you!

@picnixz picnixz deleted the feat/codecs/check-types-127691 branch December 13, 2024 16:21
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@picnixz @srinivasreddy
pythongh-127691: add type checks when using PyUnicodeError objects (p…
a7aa09b 
…ythonGH-127694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@encukou encukou Awaiting requested review from encukou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picnixz @ZeroIntensity @encukou
Morty Proxy This is a proxified and sanitized view of the page, visit original site.