gh-126662: Name consistency for xml.parsers.expat.XMLParserType#126724
Closed
tungol wants to merge 4 commits into
Closed
gh-126662: Name consistency for xml.parsers.expat.XMLParserType#126724tungol wants to merge 4 commits into
tungol wants to merge 4 commits into
Conversation
Contributor
Author
|
I think this should get fixed, but I don't know if this is the right approach or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR updates
xml.parsers.expat.XMLParserTypeto use that name consistently. I also updated the related documentation and argument clinic configuration, but I'm a little unsure about whether that last part was the right thing to do or not. It's not clear to me what risks might be involved with changing the names of the implementation methods, or what possible inconsistencies might occur if that part wasn't updated.📚 Documentation preview 📚: https://cpython-previews--126724.org.readthedocs.build/