bpo-36127: Fix compiler warning in _PyArg_UnpackKeywords().#12353
Merged
serhiy-storchaka merged 1 commit intoMar 16, 2019
python:masterpython/cpython:masterfrom
serhiy-storchaka:getargs_warn2serhiy-storchaka/cpython:getargs_warn2Copy head branch name to clipboard
Merged
bpo-36127: Fix compiler warning in _PyArg_UnpackKeywords().#12353serhiy-storchaka merged 1 commit intopython:masterpython/cpython:masterfrom serhiy-storchaka:getargs_warn2serhiy-storchaka/cpython:getargs_warn2Copy head branch name to clipboard
serhiy-storchaka merged 1 commit into
python:masterpython/cpython:masterfrom
serhiy-storchaka:getargs_warn2serhiy-storchaka/cpython:getargs_warn2Copy head branch name to clipboard
Conversation
vstinner
reviewed
Mar 18, 2019
|
|
||
| /* copy keyword args using kwtuple to drive process */ | ||
| for (i = Py_MAX(nargs, posonly); i < maxargs; i++) { | ||
| for (i = Py_MAX((int)nargs, posonly); i < maxargs; i++) { |
Member
There was a problem hiding this comment.
I'm not sure that this code is safe is nargs > INT_MAX. (int)(INT_MAX+1) gives 0, no?
Maybe write something like:
i = (nargs < INT_MAX) ? (int)nargs : INT_MAX;
i = Py_MAX(i, posonly);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
nargs <= maxpos,nargscan be casted tointwithout lost.https://bugs.python.org/issue36127