Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[3.13] gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713)#123184

Merged
markshannon merged 2 commits into
python:3.13python/cpython:3.13from
mpage:gh-122712-on-313mpage/cpython:gh-122712-on-313Copy head branch name to clipboard
Aug 21, 2024
Merged

[3.13] gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713)#123184
markshannon merged 2 commits into
python:3.13python/cpython:3.13from
mpage:gh-122712-on-313mpage/cpython:gh-122712-on-313Copy head branch name to clipboard

Conversation

@mpage

@mpage mpage commented Aug 20, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Verify the necessary properties of the function's code object in CALL_ALLOC_AND_ENTER_INIT to guard against someone reassigning code.

@mpage mpage requested a review from brandtbucher August 20, 2024 20:30
@bedevere-app bedevere-app Bot mentioned this pull request Aug 20, 2024
Closed
@mpage mpage changed the title gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713) Aug 20, 2024
@mpage mpage changed the title gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713) [3.13] gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713) Aug 20, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 20, 2024
Merged
@mpage

mpage commented Aug 20, 2024

Copy link
Copy Markdown
Contributor Author

JIT failures look like qemu issues and are unrelated to this diff:

ERROR:../../plugins/core.c:221:qemu_plugin_vcpu_init_hook: assertion failed: (success)
Bail out! ERROR:../../plugins/core.c:221:qemu_plugin_vcpu_init_hook: assertion failed: (success)
aarch64-binfmt-P: ./include/qemu/rcu.h:101: rcu_read_unlock: Assertion `p_rcu_reader->depth != 0' failed.

@mpage mpage marked this pull request as ready for review August 20, 2024 22:12
@mpage mpage requested a review from markshannon as a code owner August 20, 2024 22:12
@mpage

mpage commented Aug 20, 2024

Copy link
Copy Markdown
Contributor Author

@brandtbucher @markshannon - This is a backport of gh-122713 for 3.13. Happy to continue with this or let you take care of backporting gh-123140 to 3.13.

@markshannon markshannon merged commit 50a595b into python:3.13 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpage @markshannon
Morty Proxy This is a proxified and sanitized view of the page, visit original site.